Repository navigation
fix(cli): domain set also makes the host the site's primary domain - #57
Merged
Merged
Conversation
`cloudhal domain set <host>` only wrote cloudhal.json; the site's own domains stayed empty until a deploy called setPrimaryDomain. It now updates the local store too, so dev, render and build use the host in canonical links, the sitemap and feeds before the first deploy. Deploy still does the same on the deployment. Closes #48 Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48.
cloudhal domain set <host>only wrotecloudhal.json;Site.domainsstayed empty untilcloudhal deploycalledsetPrimaryDomain. Nowdomain setalso makes the host the local site's primary domain (other domains stay, as secondary), socloudhal dev,renderandbuilduse it in canonical links, the sitemap and feeds before any deploy.The issue's second option —
buildreadingcloudhal.json— already landed in bb0ee69 (astro.build({ site })); this covers the site's own data.packages/cli/src/commands/domain.ts:makePrimaryafter asetwith a site host.test/deploy.test.ts: checks the local site's primary right afterdomain set, before the deploy.🤖 Generated with Claude Code